Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External domains in script tags breaks build #2149

Closed
justinfagnani opened this issue Jun 10, 2016 · 16 comments
Closed

External domains in script tags breaks build #2149

justinfagnani opened this issue Jun 10, 2016 · 16 comments

Comments

@justinfagnani
Copy link
Contributor

As reported by @edoardo849 in #222

<script type="text/javascript" src="https://cdn.socket.io/socket.io-1.4.5.js"></script>

Causes an error due to no resolver being found.

@garlicnation is the standard practice to add a resolver that ignores these URLs?

@admwx7
Copy link
Contributor

admwx7 commented Jul 12, 2016

Is there a work-around for this in the meantime?

Also curious to hear what the preferred approach for handling this would be, might look into adding support if I get some free time.

@ed-ilyin
Copy link

I can't use google-chart due to this issue:
no resolver found for https://www.gstatic.com/charts/loader.js

Is there any workaround to still build somehow project?

@houston88
Copy link

I get this error as well when trying to use google-chart, and then build fails.

@garlicnation
Copy link
Contributor

@justinfagnani The NoopResolver is for this situation.

@FredKSchott
Copy link
Contributor

I just submitted a fix to this to polymer-build, which means this will get
the fix as well.
On Fri, Jul 29, 2016 at 3:24 PM AJ Ortega notifications@github.com wrote:

@justinfagnani https://github.com/justinfagnani The NoopResolver is for
this situation.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Polymer/polymer-cli/issues/261#issuecomment-236308878,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAl-k64wYPqhPHQKa9NluQ9HpYyYWSLUks5qan2JgaJpZM4IzJib
.

@FredKSchott
Copy link
Contributor

Fix in PR here: Polymer/polymer-build#16

@FredKSchott
Copy link
Contributor

Fixed in polymer-build v0.3.2 & polymer-cli v0.13.0!

@FredKSchott
Copy link
Contributor

@garlicnation is right, this only fixed half of the problem. We need to handle this in Hydrolysis as well. Working on a fix now...

@43081j
Copy link
Contributor

43081j commented Aug 8, 2016

@FredKSchott this appears to still happen in polymer lint, is it due to the same issue?

Could just be because your polymer-build version bump hasn't made it out yet, in which case ignore me.

@FredKSchott
Copy link
Contributor

@43081j no you're right, it's still happening in current polymer-cli (v0.13.0) but will be fixed in v0.14.0 (releasing today). Thanks for confirming!

@FredKSchott
Copy link
Contributor

Released! If you were running into this bug please update the CLI and re-try. Open another issue if you're still having trouble.

Thanks!

@zreptil
Copy link

zreptil commented Sep 3, 2016

Is there meanwhile a working fix for it? I run into the same issue. Google Charts is not working correctly because of this. Can i change anything in my polymer app to get it working again?

@FredKSchott
Copy link
Contributor

@zreptil you're still running into this? This was fixed in the latest version of the CLI. Have you tried updating/reinstalling?

If you're still seeing a bug, please open a new issue https://github.com/Polymer/polymer-cli/issues/new

@zreptil
Copy link

zreptil commented Sep 8, 2016

@FredKSchott

i installed polymer-cli again and run again in issues. but they weren't related to google-charts. now it seems to work correct. in my code i had to change the calls of drawChart () to redraw() for google-charts to work again. Maybe there was an update that i missed recently.

So this issue is fixed for me. Thanks for the info :)

@FredKSchott
Copy link
Contributor

Woo! Glad you were able to get it working

@jpincas
Copy link

jpincas commented Mar 6, 2017

Just posted on the PR, but reposting here:

<link rel="import" href="http://localhost:3000/admin-panel/polymer-imports.html">

and it is causing a build error.

Looking through the code a bit more closely I can see that ignoring external dependencies only applies to script and style dependencies. Is there a particular reason for this? I am importing a dynamically rendered html file from an external server which contains a lot of setup information as behaviors. It works perfectly with 'polymer serve' and seems like a good architecture. Is it unwise for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants