Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wct] TypeScript: enabling strict mode #222

Closed
merlinnot opened this issue Apr 25, 2018 · 1 comment
Closed

[wct] TypeScript: enabling strict mode #222

merlinnot opened this issue Apr 25, 2018 · 1 comment

Comments

@merlinnot
Copy link
Contributor

I'd like to go through the files and make type checking more strict, so we can enable more TypeScript checks.

Is that ok with you guys?

justinfagnani pushed a commit that referenced this issue Jul 10, 2018
* refactor the url-converter logic into the urls/ subdirectory

- doesn't change any code, just moves it
- Done in preparation for the introduction layout-based url handlers

* split ConversionMetadata into ConversionSettings & ProjectConverterInterface

- Settings are now static for a conversion session
- Now passed TO a converter, instead of mixed into each implementation

* add dependency map lookup function
@merlinnot
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant