Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wct] Moving from clang + tslint to gts #224

Closed
merlinnot opened this issue Apr 25, 2018 · 1 comment
Closed

[wct] Moving from clang + tslint to gts #224

merlinnot opened this issue Apr 25, 2018 · 1 comment

Comments

@merlinnot
Copy link
Contributor

Google has a nice tool which combines capabilities of tslint and clang fromat in one tool: https://github.com/google/ts-style

The issue with the current configuration is that clang and tslint rules are conflicting. Originally I wanted to tweak tslint configuration, but in the end I think moving to gts is a better idea.

Is that ok with you guys if I make a PR for this?
@merlinnot merlinnot mentioned this issue Apr 25, 2018
Closed
@koshilki koshilki mentioned this issue May 15, 2018
Closed
justinfagnani pushed a commit that referenced this issue Jul 10, 2018
@FredKSchott
[ProjectConverter] Refactor BaseConverter into UrlHandler, ProjectCon…
6b7b6cf 
…verter (#224)

* Refactor BaseConverter into UrlHandler, ProjectConverter

* fix the includes comment to explain the complexity of it

* respond to @usergenic PR feedback

* fix basePackageName unsafe reference

* comment on shadycss handling logic

* fix lazy endswith() matching

* remove bad url check

* npm run format

* regex too broad, lets get specific

* respond to justin feedback
@FredKSchott FredKSchott mentioned this issue Jan 3, 2019
Closed
7 tasks
@merlinnot
Copy link
Contributor Author

Closing due to inactivity.

@snyk-bot snyk-bot mentioned this issue Mar 7, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jul 17, 2020
Open
This was referenced Sep 15, 2021
Open
Open
@Exnadella Exnadella mentioned this issue May 14, 2022
Open
This was referenced Nov 26, 2023
Open
Open
@Exnadella Exnadella mentioned this issue Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wct] Use gts for linting and formatting
1 participant
@merlinnot