Adds a Polymer 3 application template to init.
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecked by depcheck.
…er-3.x; add a stub option
bicknellr
commented
Apr 13, 2018
| * @polymer | ||
| */ | ||
| class <%= elementClassName %> extends PolymerElement { | ||
| static get is() { return '<%= elementName %>'; } |
| } | ||
| } | ||
|
|
||
| window.customElements.define(<%= elementClassName %>.is, <%= elementClassName %>); |
There was a problem hiding this comment.
<%= elementClassName %>.is -> '<%= elementName %>'
bicknellr
commented
Apr 13, 2018
| "name": "<%= name %>", | ||
| <% if (description) { -%> "description": "<%= description %>", | ||
| <% } -%> | ||
| "main": "<%= name %>.js", |
bicknellr
commented
Apr 16, 2018
| .toPromise(); | ||
| // TODO(#118): Use `polymer install` once it supports installing npm | ||
| // packages. | ||
| await exec('npm install', {cwd: dir}); |
There was a problem hiding this comment.
(This PR might need to wait on #136 because of this fix: https://github.com/Polymer/tools/pull/136/files#diff-10eed550dca082f37ae2a959b6f87823R29.)
There was a problem hiding this comment.
Nope, #136 safely rewrites the exec used here. :) (edit: ..and was merged.)
|
|
||
| // TODO(#130): Add this back in when `polymer lint` has a Polymer 3 | ||
| // option. | ||
| // await runCommand(binPath, ['lint'], {cwd: dir}); |
There was a problem hiding this comment.
#142 added Polymer 3 linter rules.
| @@ -0,0 +1 @@ | |||
| bower_components/ | |||
| { | ||
| "npm": true, | ||
| "moduleResolution": "node" | ||
| } |
…nd integration test.
rictic
approved these changes
Apr 17, 2018
| @@ -116,4 +116,65 @@ export function createApplicationGenerator(templateName: string): | |||
| 'Check out your new project README for information about what to do next.\n'); | |||
| } | |||
| }; | |||
|
|
|||
| class Polymer3ApplicationGenerator extends ApplicationGenerator { | |||
| // TODO(yeoman/generator#1065): This is function not a no-op: Yeoman only | |||
There was a problem hiding this comment.
Nit, typo:
is function not -> is not
| return super.initializing(); | ||
| } | ||
|
|
||
| // TODO(yeoman/generator#1065): This is function not a no-op: Yeoman only |
| }); | ||
| } | ||
|
|
||
| // TODO(yeoman/generator#1065): This is function not a no-op: Yeoman only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.