[cli] Adds an option to init to use the Polymer 3.x compatible PSK prerelease. #169
Conversation
| @@ -76,9 +76,7 @@ export function createGithubGenerator(githubOptions: GithubGeneratorOptions): | |||
| } | |||
|
|
|||
| install() { | |||
| this.installDependencies({ | |||
| npm: false, | |||
There was a problem hiding this comment.
Did we have npm: false for just performance reasons? I'm wondering if this will cause issues for our existing generators. I'm kinda assuming no, it'll just be a bit slower?
I guess the only case I can think of would be if yeoman failed if we don't say npm: false but there also isn't a package.json file.
There was a problem hiding this comment.
I'm not sure why this was here - yeoman seems to figure this out on its own. When I init a Polymer 2 template with this change it specifically prints Running bower install for you to ... and when I init one of the Polymer 3 templates it prints Running npm install for you to ....
There was a problem hiding this comment.
Also, each of the built-in templates only has one of bower.json or package.json, PSK for Polymer 3 is soon to only have package.json, and Shop for Polymer 2 only has bower.json.
* More alarming warnings in README * Add Slack link * A little less commas * “unsaved” -> “uncommitted”
Fixes #162.