Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wct] Updated Mocha to the latest version and regenerated a lockfile. #377

Merged
merged 1 commit into from
May 18, 2018
Merged

[wct] Updated Mocha to the latest version and regenerated a lockfile. #377

merged 1 commit into from
May 18, 2018

Conversation

merlinnot
Copy link
Contributor

@merlinnot merlinnot commented May 14, 2018

Tests and build are passing locally.

Resolves #227

Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is separate from wct-browser-legacy, yeah?

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

<!-- ## Unreleased -->
<!-- Add new, unreleased items here. -->
### Security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferred format is:

## Unreleased
 * Updated Mocha to v5

@merlinnot
Copy link
Contributor Author

Thank you for a review. Yes, this is separate from wct-browser-legacy.

@merlinnot merlinnot changed the base branch from update-versions to master May 16, 2018 23:44
@merlinnot
Copy link
Contributor Author

@rictic a friendly ping :)

@rictic
Copy link
Contributor

rictic commented May 18, 2018

LGTM!

@rictic rictic merged commit 20435a1 into Polymer:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants