Remove unused callback argument to wct.cli.run and wct.cli.startSauceTunnel #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tunnel Also remove promise in wct-st, as the promise resolves immediately on sauce tunnel creation, killing the new sauce tunnel Fixes #438
usergenic
approved these changes
Jun 6, 2018
| var promise = wct.cli.run(process.env, process.argv.slice(2), process.stdout, function (error) { | ||
| process.exit(error ? 1 : 0); | ||
| }); | ||
| var promise = wct.cli.run(process.env, process.argv.slice(2), process.stdout); |
There was a problem hiding this comment.
on the next line... do you know why this call might not return a promise?
|
I think this change constrains the Or we could just rip out this behavior because it's been fairly confusing in the past. |
|
Expect error in polymer element 3.x test of polymer-cli to be transient. Merging PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove promise in wct-st, as the promise resolves immediately on
sauce tunnel creation, killing the new sauce tunnel
Fixes #438