Fix push manifest generation bugs affecting bower_components and ES modules #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix; |
Previously it looks like we were implicitly relying on the current working directory? This also means we don't have to manually fix up relative URLs in push manifest generation, so reverted that.
Fixed. PTAL. |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with push manifest generation:
Projects with bower_components were getting paths relative to the package root instead of the project root. This seems to have been a regression in 1.7 (addPushManifest treats app dependencies as siblings #433).
Projects with ES modules were crashing on push manifest generation because it was unable to resolve bundler's special sub-bundle URLs (e.g.
Unable to get document file:///private/var/folders/wz/fv09mcr569gdkbzqct263l_r003hs9/T/tmp-84970LqLvdcKS3nbH/index.html>external#1>mod1.js>es6-module: unknown).