-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release of wct-sauce, polymer-build, web-component-tester and polymer-cli. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usergenic
changed the title
Prepare release of wct-sauce, web-component-tester and polymer-cli
Prepare release of wct-sauce, polymer-build, web-component-tester and polymer-cli.
Jun 18, 2018
aomarks
approved these changes
Jun 18, 2018
packages/cli/CHANGELOG.md
Outdated
@@ -5,6 +5,11 @@ | |||
* Fix push manifest generation crash with ES module projects. | |||
<!-- Add new, unreleased items here. --> | |||
|
|||
## v1.7.4 [06-13-2018] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
06-18-2018
justinfagnani
approved these changes
Jun 18, 2018
@@ -84,7 +84,7 @@ | |||
"optionalDependencies": { | |||
"update-notifier": "^2.2.0", | |||
"wct-local": "^2.1.0", | |||
"wct-sauce": "^2.0.0" | |||
"wct-sauce": "^2.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move away from using optionalDependencies.
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that polymer-cli has a bug fix to problem in 1.7.3 polymer-cli release that appears to have been result of package update to command-line-args which is more strict on args without explicit
multiple: true
.