Fix audit warnings in polyserve #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
approved these changes
Jun 26, 2018
This was referenced Sep 12, 2021
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can verify that there are no audit warnings with the following command (make sure you ran
npm run bootstrapagain to get the correct versions):npx lerna exec --stream --scope polyserve -- npm auditNote: This PR audit fails, as the latest version of polymer-bundler is not released yet.
In 28403ca#diff-c7860144f1c9fb836793e097691c5a56 the vulnerable package
command-line-argswas updated, but it was not included in the latest release (4d137fd). Therefore, running the above command results in 1 vulnerability. Releasing a new version ofpolymer-bundlerwill resolve that.