Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer.dom.flush() only if Polymer exists #626

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

usergenic
Copy link
Contributor

From #611. This PR is just to ensure passing tests on latest rebase.

Looks like we essentially do the same in https://github.com/Polymer/tools/blob/master/packages/web-component-tester/browser/environment/helpers.ts#L128 but more so...

  let scope;
  if (window.Polymer && window.Polymer.dom && window.Polymer.dom.flush) {
    scope = window.Polymer.dom;
  } else if (window.Polymer && window.Polymer.flush) {
    scope = window.Polymer;
  } else if (window.WebComponents && window.WebComponents.flush) {
    scope = window.WebComponents;
  }
  if (scope) {
    scope.flush();
  }

I won't amend a11ysuite.js to do that yet, but it is worth noting.

@googlebot

This comment has been minimized.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no label Aug 9, 2018
@usergenic usergenic merged commit 47fb81f into master Aug 9, 2018
@usergenic usergenic deleted the polymer-flush-only-when-polymer-present branch August 9, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants