[gen-typescript-declarations] Don't import/export private features. #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
force-pushed
the
gen-tsd-dont-delete-auto-imports
branch
from
4c9e5d5
to
212dcf4
Compare
rictic
approved these changes
Aug 12, 2018
| /** | ||
| * Return whether the given Analyzer feature has "private" visibility. | ||
| */ | ||
| function isPrivate(feature: analyzer.Feature): boolean { |
There was a problem hiding this comment.
can write this as feature: analyzer.Feature & MaybePrivate
aomarks
force-pushed
the
gen-tsd-dont-delete-auto-imports
branch
from
75da8dd
to
d8c00f2
Compare
aomarks
force-pushed
the
gen-tsd-dont-delete-auto-imports
branch
from
d8c00f2
to
a213379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.