Hoist clang-format package and use a single .clang-format config in root #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage.json format scripts and added to a couple packages where missed.
|
note: I did this because I was about to add yet-another-package with yet-another-clang-format config and dependency and that felt sad. Also, this configuration makes it easier to configure editor to use the right clang-format settings because it can pull them from the workspace root instead of figuring it out per-package. |
aomarks
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason I can think of to have these all formatting rules be scattered across the monorepo's packages, so this PR standardizes all of them.
I hoisted clang-format package as well as .clang-format file to repo root, then I added format scripts to all packages that didn't have them and normalized those too. Then I ran format script for all packages, ran build, and committed what you see here.