Recognize .mjs as JavaScript files #792
Conversation
| @@ -71,6 +71,7 @@ export class AnalysisContext { | |||
| readonly parsers = new Map<string, Parser<ParsedDocument>>([ | |||
| ['html', new HtmlParser()], | |||
| ['js', new JavaScriptParser()], | |||
| ['mjs', new JavaScriptParser()], | |||
There was a problem hiding this comment.
Of course, you could create a single const jsParser = new JavaScriptParser(); and then use the the same instance for both js and mjs.
There was a problem hiding this comment.
You can also skip all the import/export scanning for .mjs files.
There was a problem hiding this comment.
Yeah, we want to add more contextual inference for treating a file as a script vs module, and .mjs would be a strong signal.
No objection to landing this as is though.
|
CI failure seems unrelated. |
|
What's blocking this? @bicknellr @justinfagnani @rictic @aomarks @usergenic |
There was a problem hiding this comment.
I think we should merge this. @rictic @aomarks @usergenic thoughts?
| @@ -71,6 +71,7 @@ export class AnalysisContext { | |||
| readonly parsers = new Map<string, Parser<ParsedDocument>>([ | |||
| ['html', new HtmlParser()], | |||
| ['js', new JavaScriptParser()], | |||
| ['mjs', new JavaScriptParser()], | |||
There was a problem hiding this comment.
Yeah, we want to add more contextual inference for treating a file as a script vs module, and .mjs would be a strong signal.
No objection to landing this as is though.
This is a quick and dirty fix for #736.