Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objectWithoutPropertiesLoose to generate-helpers.js #835

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Add objectWithoutPropertiesLoose to generate-helpers.js #835

merged 2 commits into from
Jan 2, 2019

Conversation

RobMaskell
Copy link
Contributor

The babel helper objectWithoutProperties calls objectWithoutPropertiesLoose which needs to be included in generate-helpers.js in the build package in order to avoid an error.
I found this while testing with "@babel/core": "^7.2.2" which fixes an issue I had with rest/spread operators not working in the version of babel used by polymer.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@RobMaskell
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@RobMaskell RobMaskell changed the title Added objectWithoutPropertiesLoose to generate-helpers.js Add objectWithoutPropertiesLoose to generate-helpers.js Dec 27, 2018
@RobMaskell
Copy link
Contributor Author

Doesn't look like the build failure is anything to do with my change, seems to be expecting Chrome 69+ but getting 62

@RobMaskell
Copy link
Contributor Author

Might be related to this 2f10194

@aomarks aomarks merged commit 6f79e01 into Polymer:master Jan 2, 2019
@RobMaskell
Copy link
Contributor Author

@aomarks does this need to be released on it's own of does it get sucked by something else?

@armujahid
Copy link
Contributor

It's strange but I am still getting this error in IE from code compiled using latest polymer cli v1.9.11
Object doesn't support property or method 'objectWithoutPropertiesLoose'
I can see that generate helper file has objectWithoutPropertiesLoose so I am not sure what's the root cause.

'objectWithoutPropertiesLoose',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants