-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add objectWithoutPropertiesLoose to generate-helpers.js #835
Add objectWithoutPropertiesLoose to generate-helpers.js #835
Conversation
…Loose now included in generate-helpers.js
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Doesn't look like the build failure is anything to do with my change, seems to be expecting Chrome 69+ but getting 62 |
Might be related to this 2f10194 |
@aomarks does this need to be released on it's own of does it get sucked by something else? |
It's strange but I am still getting this error in IE from code compiled using latest polymer cli v1.9.11
|
The babel helper objectWithoutProperties calls objectWithoutPropertiesLoose which needs to be included in generate-helpers.js in the build package in order to avoid an error.
I found this while testing with "@babel/core": "^7.2.2" which fixes an issue I had with rest/spread operators not working in the version of babel used by polymer.