-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to app-route #100
Comments
Wow! Nice news! |
Yay! If we rename the repo (and I think we should) then this does require a major version bump to prevent breaking existing users, so we can call the app-router release Do we have a date before which we want to land this rename? Doing two major version bumps wouldn't be much of a problem if the rename needs to land quick. |
Agreed on bumping to 0.9. Let's try to land this rename early next week, so if that can coincide with the other breaking change that'd be perfect. |
There already is Erik Ringsmuth's https://github.com/erikringsmuth/app-router... Just saying. |
@atomikolex Well, change one character... route vs router. 😅 |
Sure thing. Just thought the similarity may actually enhance confusion for older users. Also, as this namespace falls in line with the app-layout lab elements, it may be difficult to understand why these new elements would be all about building apps - compared to the paper, neon, gold, or platinum elements. If you are breaking your naming system in order to respond to the above feedback, maybe you should do a full reshuffle across all element lines, and strip the abstractness and fragmentation of the current system. Why not model a new system on a short and catchy namespace, like Angular's -ng? |
@atomikolex Agreed, a full reshuffle is probably the goal, to get more concrete and less abstract. It would be a big catalog-wide breaking change though, so this current plan is a bit to test the waters with changing a single name of a new element and also introduce some forthcoming new elements with the app-* name. If it works out, we'll be able to have a little more data and be able to plan a better more for a larger rename. |
As always, I am sure you will come up with a good solution, if you need to make that change. For a big overhaul, my vote would be for a unified system, taking in the Polymer brand somehow. |
This should be closed? @rictic |
Yep! |
It is time.
We've gotten continual and well-reasoned feedback that the periodic-table element naming scheme is cute but very confusing, especially for new developers coming to Polymer and the components.
Since the "carbon" elements are a new product line and really all about building apps, let's just call them what they are: the app-* elements.
Question: this should probably warrant a major version bump?
Task list (added by rictic):
The text was updated successfully, but these errors were encountered: