Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to app-route #100

Closed
5 tasks done
tjsavage opened this issue May 12, 2016 · 10 comments
Closed
5 tasks done

Rename to app-route #100

tjsavage opened this issue May 12, 2016 · 10 comments

Comments

@tjsavage
Copy link

tjsavage commented May 12, 2016

It is time.

We've gotten continual and well-reasoned feedback that the periodic-table element naming scheme is cute but very confusing, especially for new developers coming to Polymer and the components.

Since the "carbon" elements are a new product line and really all about building apps, let's just call them what they are: the app-* elements.

Question: this should probably warrant a major version bump?

Task list (added by rictic):

  • rename in this repo's source code
  • rename the repo itself
  • stamp v0.9.0
  • update the docs repo
  • update the blog post
@abdonrd
Copy link
Member

abdonrd commented May 12, 2016

Wow! Nice news!

@rictic
Copy link
Collaborator

rictic commented May 12, 2016

Yay!

If we rename the repo (and I think we should) then this does require a major version bump to prevent breaking existing users, so we can call the app-router release v0.9.0. At the same time, we're taking a look at PR #77 around this weekend which is a (small) breaking change as well.

Do we have a date before which we want to land this rename? Doing two major version bumps wouldn't be much of a problem if the rename needs to land quick.

@tjsavage
Copy link
Author

Agreed on bumping to 0.9.

Let's try to land this rename early next week, so if that can coincide with the other breaking change that'd be perfect.

@atomikolex
Copy link

There already is Erik Ringsmuth's https://github.com/erikringsmuth/app-router... Just saying.

@abdonrd
Copy link
Member

abdonrd commented May 13, 2016

@atomikolex Well, change one character... route vs router. 😅
PolymerElements/app-route vs erikringsmuth/app-router

@atomikolex
Copy link

atomikolex commented May 13, 2016

Sure thing. Just thought the similarity may actually enhance confusion for older users.

Also, as this namespace falls in line with the app-layout lab elements, it may be difficult to understand why these new elements would be all about building apps - compared to the paper, neon, gold, or platinum elements.

If you are breaking your naming system in order to respond to the above feedback, maybe you should do a full reshuffle across all element lines, and strip the abstractness and fragmentation of the current system. Why not model a new system on a short and catchy namespace, like Angular's -ng?

@tjsavage
Copy link
Author

@atomikolex Agreed, a full reshuffle is probably the goal, to get more concrete and less abstract. It would be a big catalog-wide breaking change though, so this current plan is a bit to test the waters with changing a single name of a new element and also introduce some forthcoming new elements with the app-* name. If it works out, we'll be able to have a little more data and be able to plan a better more for a larger rename.

@atomikolex
Copy link

As always, I am sure you will come up with a good solution, if you need to make that change. For a big overhaul, my vote would be for a unified system, taking in the Polymer brand somehow.

rictic added a commit that referenced this issue May 13, 2016
rictic added a commit that referenced this issue May 13, 2016
rictic added a commit that referenced this issue May 13, 2016
rictic added a commit that referenced this issue May 13, 2016
rictic added a commit that referenced this issue May 16, 2016
rictic added a commit that referenced this issue May 16, 2016
rictic added a commit to Polymer/old-docs-site that referenced this issue May 16, 2016
rictic added a commit to googlearchive/blog that referenced this issue May 16, 2016
@gaurav21r
Copy link

This should be closed? @rictic

@rictic
Copy link
Collaborator

rictic commented May 25, 2016

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants