from polymerelements to PolymerElements in 2.0-preview #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdrinkoshi
requested changes
Apr 25, 2017
|
Dear Valdrin Koshi Thank you for looking into this. I have created a pull request in the 1.x master branch as well in #244 I'm tracking the progress of all these changes in a comment with checkboxes in |
|
Hi @bartolom, sorry for the confusion, I meant to ask to modify also line 54 (which is the "1.x" block in the bower.json). |
|
LGTM, will merge this anyways in 2.0-preview and resolve the conflicts in that branch 👌 |
valdrinkoshi
added a commit
that referenced
this pull request
May 13, 2017
* port to 2.0 * loop over effective children instead of using nextElementSibling * query the element rather than the slot * flush ShadyDOM on attached, remove flush from tests * use variants * update deps and resolutions * Depend on test-fixture v2 * auto-generated: update repo for v2 * remove flushing * distribute both 1.x and 2.x style. Fix tests. * hybrid distribution for iron-icon * update deps * Point to Polymer 2.0 RC 1 * Update travis config * wait for distribution in tests * named slot * promote use of slot * slot selectors in tests * menu -> dropdownMenu * remove test-fixture-mocha.js * keep :host-context in case :dir doesn't exist * Explain why we check for nodeType * use Polymer.Base.async * [skip ci] more diff-friendly change * include web animations polyfill devDependency * [skip ci] update readme * Consistent use of CamelCase in bower dependencies (#243) * Update travis config (#245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wants to make this Polymer element consistent with the majority of other Polymer elements in the 2.0-preview branch. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL.
The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency.
I fixed this in the "2.0-preview" branch of this element, because it would be very nice to have this cleaned up and consistent in 2.0 release. I have manually checked 66 elements that have a "2.0-preview" branch. 56 are ok. This element is one of 10 which has these small differences.
This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.