Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect target inside a shadow root for clickOutsideHandler #1

Merged
merged 10 commits into from
Aug 7, 2020

Conversation

ywsang
Copy link
Collaborator

@ywsang ywsang commented Jul 30, 2020

Suggested merge commit message, following CKEditor's convention:

Other (ui): Look at event's composed path to detect a target in shadow root. Closes ckeditor#7743.


Looks at the event's composed path (when available) to add support for the editor being run in a shadow root. Due to event retargeting, target appears to be the entire editor when it's in a shadow root, causing a click to be seen as not coming from a context element when it actually did.

@ywsang ywsang requested a review from justinfagnani July 30, 2020 14:54
Copy link

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have a question about the tests and whether we're running them like upstream is, and in all the browsers. I think we'll want to get continuous integration set up.

@ywsang ywsang merged commit 8824191 into shadow-root-support Aug 7, 2020
@ywsang ywsang deleted the click-outside-handler branch August 7, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants