Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Node perf tester #4

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Node perf tester #4

merged 4 commits into from
Oct 4, 2017

Conversation

TimvdLippe
Copy link
Contributor

Add a node interface for the perf-tester. It uses chrome headless if no port is specified. It parses a series of options which it will navigate to, perform the timings and then extract window.perfTiming from the Runtime.

sorvell
sorvell suggested changes Sep 2, 2017
View reviewed changes
options.json Outdated
@@ -0,0 +1,4 @@
[
["original", "http://localhost:8081/youtube/"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be removed, right?

perf.js Outdated
}
};

// x-browser compat.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff here is weird. What happened?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line endings were mixed. I changed all lines to LF.

@TimvdLippe
Copy link
Contributor Author

@sorvell I updated the line endings, so the diff is less nice 😢 I updated console._perfEnd to take an options object to disable the force layout, as well as expose the actual timing in window.perfTiming, such that the node script can use it. I also added some documentation on how to use the script.

@hastebrot
Copy link

hastebrot commented Sep 13, 2017 •
edited

I updated the line endings, so the diff is less nice

Using w=1 (ignore whitespace; similar to git diff --ignore-all-space) in the URL for the diff viewer (compare) helps a bit:
https://github.com/PolymerLabs/perf-tester/pull/4/files?diff=unified&w=1

@sorvell sorvell merged commit e2baa5c into master Oct 4, 2017
@sorvell sorvell deleted the node-perf-tester branch October 4, 2017 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorvell sorvell sorvell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimvdLippe @hastebrot @sorvell