Asynchronous Performance Speedups #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleblloyd
force-pushed
the
f_performance
branch
2 times, most recently
from
ce363ca
to
3a08ee0
Compare
caleblloyd
force-pushed
the
f_performance
branch
from
3a08ee0
to
97e0538
Compare
yukozh
reviewed
Sep 21, 2016
| @@ -1,4 +1,4 @@ | |||
| # Pomelo.EntityFrameworkCore.MySql | |||
| # Pomelo.EntityFrameworkCore.MySql | |||
There was a problem hiding this comment.
oops, probably file encoding. removed from the commit
| // ReSharper disable once CheckNamespace | ||
| namespace Microsoft.EntityFrameworkCore.Query | ||
| { | ||
| public class MySqlRelationalQueryContext : RelationalQueryContext |
There was a problem hiding this comment.
MySqlQueryContext. No MySqlRelationalQueryContext.
| { | ||
| public bool HasInclude = false; | ||
|
|
||
| public MySqlRelationalQueryContext( |
| namespace Microsoft.EntityFrameworkCore.Query.Internal | ||
| { | ||
| public class MySqlRelationalQueryContextFactory : RelationalQueryContextFactory | ||
| { |
caleblloyd
force-pushed
the
f_performance
branch
from
97e0538
to
eb1362e
Compare
|
Code review changes complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on achieving maximum Asynchronous method throughput. It implements the following speedups:
Includeare now wrapped in RepeatableRead transactions so that they get a consistent snapshot of the databaseWith this PR, Async behavior scales well without lock-ups. I am able to hit 500RPS in the performance tests and maintain under a 1s response time.