Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken for CMake MacOS #767

Closed
dechamps opened this issue Feb 18, 2023 · 4 comments · Fixed by #768
Closed

CI is broken for CMake MacOS #767

dechamps opened this issue Feb 18, 2023 · 4 comments · Fixed by #768
Labels
CI Continuous Integration including GitHub Actions P2 Priority: High
Milestone

Comments

@dechamps
Copy link
Contributor

PortAudio continuous integration (GitHub Actions) appears to be consistently failing for "macOS Clang" on latest master (4bccdfb):

-- Fixing pkgconfig file: /Users/runner/work/portaudio/portaudio/vcpkg/packages/jack2_x64-osx/lib/pkgconfig/jack.pc
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:641 (message):
  Could not find pkg-config.  Please install it via your package manager:

      brew install pkg-config
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:198 (vcpkg_find_acquire_program)
  ports/jack2/portfile.cmake:21 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:145 (include)


error: building jack2:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `./vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+jack2
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[jack2]+Build+error
including:
  package: jack2[core]:x64-osx -> 1.9.21
    vcpkg-tool version: 2022-03-30-692785ac944e81417840c6de244fb3e18a4b35eb
    vcpkg-scripts version: f30786c9c 2022-05-02 (10 months ago)

Additionally, attach any relevant sections from the log files above.
-- Running vcpkg install - failed
CMake Error at vcpkg/scripts/buildsystems/vcpkg.cmake:853 (message):
  vcpkg install failed.  See logs for more information:
  /Users/runner/work/portaudio/portaudio/build/vcpkg-manifest-install.log
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.25.2/share/cmake/Modules/CMakeDetermineSystem.cmake:124 (include)
  CMakeLists.txt:2 (project)


CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
-- Configuring incomplete, errors occurred!
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
Error: Process completed with exit code 1.
@dechamps
Copy link
Contributor Author

dechamps commented Feb 18, 2023

At first I thought this might be caused by GitHub Actions upgrading macOS-latest from macOS-11 to macOS-12 (see actions/runner-images#6384) but that's not it - it fails in the exact same way if I try it with macOS-11.

dechamps added a commit to dechamps/portaudio that referenced this issue Feb 18, 2023
dechamps added a commit to dechamps/portaudio that referenced this issue Feb 18, 2023
@philburk
Copy link
Collaborator

Thanks for figuring this out.

@RossBencina RossBencina added CI Continuous Integration including GitHub Actions P1 Priority: Highest labels Feb 20, 2023
@RossBencina
Copy link
Collaborator

Seems like GitHub must have changed something with their CI since we didn't change anything. It started failing on our last comment: 4bccdfb which was purely a documentation update.

I'm going to merge the PR as an emergency fix for CI.

But I'd like to keep this discussion open until I understand why it broke and why we have a vcpkg dependency on MacOS. Seems like the better fix might be to get rid of the vcpkg dependency?

@RossBencina RossBencina added P2 Priority: High and removed P1 Priority: Highest labels Feb 21, 2023
@RossBencina RossBencina added this to the V19.8 milestone Feb 21, 2023
@RossBencina RossBencina reopened this Feb 21, 2023
@RossBencina
Copy link
Collaborator

Moved discussion of vcpkg dependency to #777. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration including GitHub Actions P2 Priority: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants