Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test that tries to use the generated CMake libs [continuation]. #866

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Add a test that tries to use the generated CMake libs [continuation]. #866

merged 2 commits into from
Dec 22, 2023

Conversation

dmitrykos
Copy link
Collaborator

It is a continuation of stalled (and thus closed) PR #671.

@dmitrykos dmitrykos added the build-cmake CMake build system label Dec 2, 2023
@dmitrykos dmitrykos self-assigned this Dec 2, 2023
@dmitrykos dmitrykos mentioned this pull request Dec 2, 2023
Closed
@dmitrykos
Copy link
Collaborator Author

dmitrykos commented Dec 2, 2023 •
edited
Loading

Besides the fix of #671 this PR now also fixes CI pipeline due to outdated vcpkg commit Id that was causing MSVC and MinGW build failure although was working well before. The reason was missing dependency msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst of vcpkg (see the log: https://github.com/PortAudio/portaudio/actions/runs/7068869852/job/19244121509).

Now it is set to the latest (microsoft/vcpkg@ca9ac0b) and works well.

@dmitrykos
Copy link
Collaborator Author

Just noticed that other PRs, like #863, are failing CI (CMake build / Windows MSVC, CMake build / Windows MinGW). @RossBencina, @philburk could you please review this PR to restore PA CI.

@RossBencina
Copy link
Collaborator

Does this remove the vcpkg dependency on Mac CI? (i.e. does it close #777)

philburk
philburk approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!
I don't fully understand it but CI is passing.
So that is a good thing.

RossBencina
RossBencina approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dmitry. I don't understand what you've done here but I'm OK moving forward with this.

.github/workflows/cmake.yml
cmake_options:
-DPA_USE_ASIO=ON
-DPA_USE_JACK=OFF
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a ticket regarding this issue please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is linker error, so it is outside PA and either Jack dependency must be fixed or MinGW-64 linker has to be changed. I can create ticket to trace this issue although we could simply revise DPA_USE_JACK=OFF after some time.

@philburk philburk merged commit 3c11534 into PortAudio:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBencina RossBencina RossBencina approved these changes

@philburk philburk philburk approved these changes

Assignees

@dmitrykos dmitrykos

Labels
build-cmake CMake build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrykos @RossBencina @philburk