GitHub Action to spellcheck and lint Python code #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
codespell_and_ruff
branch
from
7f7acfd to
d27fbbd
Compare
cclauss
commented
Apr 27, 2024
| @@ -29,7 +29,7 @@ def loadCsvData( dataFileName ): | |||
| inputDevice = "" | |||
| outputDevice = "" | |||
|
|
|||
| startLines = file(dataFileName).readlines(1024) | |||
| startLines = open(dataFileName).readlines(1024) | |||
There was a problem hiding this comment.
The from pylab import * above was hiding the file() issue that is just like:
|
I'd prefer to consider the python fixes and the CI workflow as separate PRs. The fixes are uncontroversial and can me merged as is (although maybe an additional improvement is to explicitly scope the The CI I'm not sure about due to imposing linting opinions that I have no idea about since I've never used ruff or codespell. |
|
Removed the CI workflow. |
philburk
approved these changes
May 10, 2024
RossBencina
approved these changes
May 10, 2024
|
Thank you! |
cclauss
added a commit
to cclauss/portaudio-1
that referenced
this pull request
May 11, 2024
The CI automation part that was removed from * PortAudio#899 * PortAudio#898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Action uses minimal steps to run in ~5 seconds to rapidly:
codespellto look for typos in the codebase, andruffto lint Python code and provide intuitive GitHub Annotations to contributors.Tools:
@RossBencina