Supporting currency in payment and registration #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is someone maintaining this repo? |
|
Yes, the project is active, unfortunately we don't have time to validate the changes at the moment as other projects have higher priority. Your change is more of an extension than a bug in the library. |
|
Hi @tinohager, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment and registration have the possibility to submit currency codes. For registration this was hardcoded to Euro and for payment no parameter was available.
I added an ISO 4217 CurrencyCode enum (sourced from wikipedia, which itself sourced it from ISO itself) and added it to RegistrationConfig and as an optional parameter to the ZvtClient.Payment method.
A unit test was added for payment and I also tried it locally with an Ingenico Move 5000 - the currency was submitted and the payment process was successfull. With a different currency than the main currency the Move 5000 anborted the transaction, but this is expected and the expected error message ("currency not applicable") was returned from the PT.
I also expanded the ControlPanel.