Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting currency in payment and registration #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tofi92
Copy link

@tofi92 tofi92 commented Jun 6, 2024

Payment and registration have the possibility to submit currency codes. For registration this was hardcoded to Euro and for payment no parameter was available.

I added an ISO 4217 CurrencyCode enum (sourced from wikipedia, which itself sourced it from ISO itself) and added it to RegistrationConfig and as an optional parameter to the ZvtClient.Payment method.

A unit test was added for payment and I also tried it locally with an Ingenico Move 5000 - the currency was submitted and the payment process was successfull. With a different currency than the main currency the Move 5000 anborted the transaction, but this is expected and the expected error message ("currency not applicable") was returned from the PT.

I also expanded the ControlPanel.

@tofi92
Copy link
Author

tofi92 commented Aug 12, 2024

Hi, is someone maintaining this repo?

@tinohager
Copy link
Member

Yes, the project is active, unfortunately we don't have time to validate the changes at the moment as other projects have higher priority.

Your change is more of an extension than a bug in the library.

@tofi92
Copy link
Author

tofi92 commented Aug 12, 2024

Hi @tinohager,
no worries, I just feared noone saw this or the repo was dead 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants