Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update classes with latest openai signature #70

Merged
merged 6 commits into from
Jan 12, 2024
Merged

feat: update classes with latest openai signature #70

merged 6 commits into from
Jan 12, 2024

Conversation

VisargD
Copy link
Collaborator

@VisargD VisargD commented Jan 12, 2024 •
edited
Loading

Title: update classes with latest openai signature

Description:

  • Add logprobs and top_logprobs to ModelParams model.
  • Add ToolCall and DeltaToolCall (for stream) classes for response.
  • Add tools and tools_choice to ModelParams.
  • Add tool_calls to Message model to allow tool calls response.
  • Make content optional in Message model to allow tool_calls response which does not send content as a string.

Motivation:

  • To accomodate latest signature updates of openai like tool_calls and logprobs

Related Issues:

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:enhancement labels Jan 12, 2024
@ayush-portkey ayush-portkey merged commit b7bdd11 into main Jan 12, 2024
6 checks passed
@ayush-portkey ayush-portkey deleted the feat/update-types-and-validation branch January 12, 2024 17:34
@VisargD VisargD mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrushankportkey vrushankportkey Awaiting requested review from vrushankportkey

Assignees
No one assigned
Labels
auto:enhancement size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow tools, tool_choice, logprobs and top_logprobs for chat completions
2 participants
@VisargD @ayush-portkey