Fix tests by :any-ing catch errors

src/healthcheck.ts

@@ -13,7 +13,7 @@ export async function healthcheck(): Promise<boolean> {
             status.error('💔', 'Redis key @posthog-plugin-server/ping not found! Plugin server seems to be offline')
             return false
         }
-    } catch (error) {
+    } catch (error: any) {
         status.error('💥', 'An unexpected error occurred:', error)
         return false
     } finally {

src/index.ts

@@ -69,7 +69,7 @@ switch (alternativeMode) {
                 status.info(`✅`, `Graphile migrations are now up to date!`)
                 await graphile.disconnectProducer()
                 process.exit(0)
-            } catch (error) {
+            } catch (error: any) {
                 status.error('🔴', 'Error running migrations for Graphile Worker!\n', error)
                 process.exit(1)
             }

src/main/ingestion-queues/celery-queue.ts

@@ -30,7 +30,7 @@ export class CeleryQueue extends Base implements Queue {
         this.handlers[name] = function registHandler(...args: any[]): Promise<any> {
             try {
                 return Promise.resolve(handler(...args))
-            } catch (err) {
+            } catch (err: any) {
                 return Promise.reject(err)
             }
         }

src/main/ingestion-queues/ingest-event.ts

@@ -75,7 +75,7 @@ async function runInstrumentedFunction({
     const timer = new Date()
     try {
         return await func(event)
-    } catch (error) {
+    } catch (error: any) {
         status.info('🔔', error)
         Sentry.captureException(error)
         throw error

src/main/ingestion-queues/kafka-queue.ts

@@ -99,7 +99,7 @@ export class KafkaQueue implements Queue {
                 eachBatch: async (payload) => {
                     try {
                         await this.eachBatch(payload)
-                    } catch (error) {
+                    } catch (error: any) {
                         status.info('💀', `Kafka batch of ${payload.batch.messages.length} events failed!`)
                         if (error.type === 'UNKNOWN_MEMBER_ID') {
                             status.info(
@@ -142,7 +142,7 @@ export class KafkaQueue implements Queue {
         try {
             await this.consumer.stop()
             status.info('⏹', 'Kafka consumer stopped!')
-        } catch (error) {
+        } catch (error: any) {
             status.error('⚠️', 'An error occurred while stopping Kafka queue:\n', error)
         }
         try {

src/main/ingestion-queues/queue.ts

@@ -63,7 +63,7 @@ export async function startQueues(
             queues.ingestion = await startQueueKafka(server, piscina, mergedWorkerMethods)
         }
         return queues
-    } catch (error) {
+    } catch (error: any) {
         status.error('💥', 'Failed to start event queue:\n', error)
         throw error
     }
@@ -93,7 +93,7 @@ function startQueueRedis(server: Hub, piscina: Piscina, workerMethods: WorkerMet
                 }
                 pauseQueueIfWorkerFull(() => celeryQueue.pause(), server, piscina)
                 await piscina?.run({ task: 'enqueueJob', args: { job } })
-            } catch (e) {
+            } catch (e: any) {
                 Sentry.captureException(e)
             }
         }
@@ -125,7 +125,7 @@ function startQueueRedis(server: Hub, piscina: Piscina, workerMethods: WorkerMet
                 try {
                     const checkAndPause = () => pauseQueueIfWorkerFull(() => celeryQueue.pause(), server, piscina)
                     await ingestEvent(server, workerMethods, event, checkAndPause)
-                } catch (e) {
+                } catch (e: any) {
                     Sentry.captureException(e)
                 }
             }

src/main/job-queues/concurrent/graphile-queue.ts

@@ -118,7 +118,7 @@ export class GraphileQueue extends JobQueueBase {
             const pool = createPostgresPool(configOrDatabaseUrl, onError)
             try {
                 await pool.query('select 1')
-            } catch (error) {
+            } catch (error: any) {
                 reject(error)
             }
             resolved = true

src/main/job-queues/job-queue-consumer.ts

@@ -27,7 +27,7 @@ export async function startJobQueueConsumer(server: Hub, piscina: Piscina): Prom
             status.info('🔄', 'Job queue consumer lock acquired')
             try {
                 await server.jobQueueManager.startConsumer(onJob)
-            } catch (error) {
+            } catch (error: any) {
                 try {
                     logOrThrowJobQueueError(server, error, `Can not start job queue consumer!`)
                 } catch {

src/main/job-queues/job-queue-manager.ts

@@ -34,7 +34,7 @@ export class JobQueueManager implements JobQueue {
                 try {
                     await jobQueue.connectProducer()
                     status.info('🚶', `Connected to job queue producer "${jobQueueType}"`)
-                } catch (error) {
+                } catch (error: any) {
                     toRemove.add(jobQueue)
                     logOrThrowJobQueueError(
                         this.pluginsServer,
@@ -54,7 +54,7 @@ export class JobQueueManager implements JobQueue {
             try {
                 await jobQueue.enqueue(job)
                 return
-            } catch (error) {
+            } catch (error: any) {
                 // if one fails, take the next queue
                 Sentry.captureException(error, {
                     extra: {

src/main/pluginsServer.ts

@@ -245,7 +245,7 @@ export async function startPluginsServer(
         hub.lastActivityType = 'serverStart'
 
         return serverInstance as ServerInstance
-    } catch (error) {
+    } catch (error: any) {
         Sentry.captureException(error)
         status.error('💥', 'Launchpad failure!', error)
         void Sentry.flush().catch(() => null) // Flush Sentry in the background

src/main/services/mmdb.ts

@@ -49,7 +49,7 @@ async function decompressAndOpenMmdb(brotliContents: Buffer, filename: string):
                 )
                 try {
                     resolve(Reader.openBuffer(result))
-                } catch (e) {
+                } catch (e: any) {
                     reject(e)
                 }
             }
@@ -119,7 +119,7 @@ async function distributableFetchAndInsertFreshMmdb(
         const mmdb = await fetchAndInsertFreshMmdb(hub)
         await hub.db.redisSet(MMDB_STATUS_REDIS_KEY, MMDBFileStatus.Idle)
         return mmdb
-    } catch (e) {
+    } catch (e: any) {
         // In case of an error mark the MMDB feature unavailable for an hour
         await hub.db.redisSet(MMDB_STATUS_REDIS_KEY, MMDBFileStatus.Unavailable, 120)
         status.error('❌', 'An error occurred during MMDB fetch and insert:', e)
@@ -230,7 +230,7 @@ export async function createMmdbServer(serverInstance: MMDBPrepServerInstance):
                 if (serverInstance.mmdb) {
                     try {
                         responseData = serverInstance.mmdb.city(partialData.toString().trim())
-                    } catch (e) {
+                    } catch (e: any) {
                         responseData = null
                     }
                 } else {

src/utils/celery/broker.ts

@@ -172,7 +172,7 @@ export class Broker implements Pausable {
             } else {
                 this.receiveSlow(resolve, queue, callback)
             }
-        } catch (error) {
+        } catch (error: any) {
             status.error('⚠️', 'An error occured in Celery broker:\n', error)
         }
     }

src/utils/db/db.ts

@@ -164,7 +164,7 @@ export class DB {
                 const response = await transaction(client)
                 await client.query('COMMIT')
                 return response
-            } catch (e) {
+            } catch (e: any) {
                 await client.query('ROLLBACK')
                 throw e
             } finally {
@@ -210,7 +210,7 @@ export class DB {
                     return defaultValue
                 }
                 return value ? (jsonSerialize ? JSON.parse(value) : value) : null
-            } catch (error) {
+            } catch (error: any) {
                 if (error instanceof SyntaxError) {
                     // invalid JSON
                     return null
@@ -670,7 +670,7 @@ export class DB {
                 [target.id, source.id, target.team_id],
                 'updateDistinctIdPerson'
             )
-        } catch (error) {
+        } catch (error: any) {
             if (
                 error.message.includes(
                     'insert or update on table "posthog_persondistinctid" violates foreign key constraint'
@@ -890,7 +890,7 @@ export class DB {
                     )
                 }
             })
-        } catch (error) {
+        } catch (error: any) {
             // Throw further if not postgres error nr "23505" == "unique_violation"
             // https://www.postgresql.org/docs/12/errcodes-appendix.html
             if (error.code !== '23505') {
@@ -939,7 +939,7 @@ export class DB {
                     topic: KAFKA_PLUGIN_LOG_ENTRIES,
                     messages: [{ key: parsedEntry.id, value: Buffer.from(JSON.stringify(parsedEntry)) }],
                 })
-            } catch (e) {
+            } catch (e: any) {
                 captureException(e)
                 console.error(parsedEntry)
                 console.error(e)
@@ -972,7 +972,7 @@ export class DB {
                 values,
                 'insertPluginLogEntries'
             )
-        } catch (e) {
+        } catch (e: any) {
             captureException(e)
             console.error(e)
         }

src/utils/db/hub.ts

@@ -205,7 +205,7 @@ export async function createHub(
 
     try {
         await hub.jobQueueManager.connectProducer()
-    } catch (error) {
+    } catch (error: any) {
         try {
             logOrThrowJobQueueError(hub as Hub, error, `Can not start job queue producer!`)
         } catch {

src/utils/db/kafka-producer-wrapper.ts

@@ -79,7 +79,7 @@ export class KafkaProducerWrapper {
                 await this.producer.sendBatch({
                     topicMessages: messages,
                 })
-            } catch (err) {
+            } catch (err: any) {
                 // :TODO: Implement some retrying, https://github.com/PostHog/plugin-server/issues/511
                 this.statsd?.increment('query.kafka_send.failure')
                 throw err

src/utils/redlock.ts

@@ -62,7 +62,7 @@ export async function startRedlock({
                 try {
                     lock = await lock.extend(lockTTL)
                     lockTimeout = setTimeout(extendLock, extendDelay)
-                } catch (error) {
+                } catch (error: any) {
                     status.error('🔴', `Redlock cannot extend lock "${resource}":\n`, error)
                     Sentry.captureException(error, { extra: { resource } })
                     weHaveTheLock = false
@@ -73,7 +73,7 @@ export async function startRedlock({
             lockTimeout = setTimeout(extendLock, extendDelay)
 
             await onLock?.()
-        } catch (error) {
+        } catch (error: any) {
             if (stopped) {
                 return
             }

src/utils/utils.ts

@@ -45,10 +45,10 @@ export function bufferToStream(binary: Buffer): Readable {
 export async function getFileFromArchive(archive: Buffer, file: string): Promise<string | null> {
     try {
         return getFileFromZip(archive, file)
-    } catch (e) {
+    } catch (e: any) {
         try {
             return await getFileFromTGZ(archive, file)
-        } catch (e) {
+        } catch (e: any) {
             throw new Error(`Could not read archive as .zip or .tgz`)
         }
     }
@@ -370,7 +370,7 @@ export async function tryTwice<T extends any>(
     try {
         const response = await Promise.race([timeout, callback()])
         return response as T
-    } catch (error) {
+    } catch (error: any) {
         Sentry.captureMessage(`Had to run twice: ${errorMessage}`)
         // try one more time
         return await callback()

src/worker/ingestion/hooks.ts

@@ -133,7 +133,7 @@ export function getFormattedMessage(
         }
         messageText = format(tokenizedMessage, ...values)
         messageMarkdown = format(tokenizedMessage, ...markdownValues)
-    } catch (error) {
+    } catch (error: any) {
         const [actionName, actionMarkdown] = getActionDetails(action, siteUrl, webhookType)
         messageText = `⚠ Error: There are one or more formatting errors in the message template for action "${actionName}".`
         messageMarkdown = `*⚠ Error: There are one or more formatting errors in the message template for action "${actionMarkdown}".*`

src/worker/ingestion/ingest-event.ts

@@ -34,7 +34,7 @@ export async function ingestEvent(hub: Hub, event: PluginEvent): Promise<IngestE
         // We don't want to return the inserted DB entry that `processEvent` returns.
         // This response is passed to piscina and would be discarded anyway.
         return { success: true }
-    } catch (e) {
+    } catch (e: any) {
         status.info('🔔', e)
         Sentry.captureException(e)
         return { error: e.message }

src/worker/ingestion/process-event.ts

@@ -99,7 +99,7 @@ export class EventsProcessor {
             })
             try {
                 await this.handleIdentifyOrAlias(data['event'], properties, distinctId, teamId)
-            } catch (e) {
+            } catch (e: any) {
                 console.error('handleIdentifyOrAlias failed', e, data)
                 Sentry.captureException(e, { extra: { event: data } })
             } finally {
@@ -170,7 +170,7 @@ export class EventsProcessor {
                     // timestamp and sent_at must both be in the same format: either both with or both without timezones
                     // otherwise we can't get a diff to add to now
                     return now.plus(DateTime.fromJSDate(new Date(data['timestamp'])).diff(sentAt))
-                } catch (error) {
+                } catch (error: any) {
                     status.error('⚠️', 'Error when handling timestamp:', error)
                     Sentry.captureException(error, { extra: { data, now, sentAt } })
                 }
@@ -292,7 +292,7 @@ export class EventsProcessor {
             try {
                 await this.db.addDistinctId(oldPerson, distinctId)
                 // Catch race case when somebody already added this distinct_id between .get and .addDistinctId
-            } catch (error) {
+            } catch (error: any) {
                 Sentry.captureException(error)
                 // integrity error
                 if (retryIfFailed) {
@@ -307,7 +307,7 @@ export class EventsProcessor {
             try {
                 await this.db.addDistinctId(newPerson, previousDistinctId)
                 // Catch race case when somebody already added this distinct_id between .get and .addDistinctId
-            } catch (error) {
+            } catch (error: any) {
                 Sentry.captureException(error)
                 // integrity error
                 if (retryIfFailed) {
@@ -324,7 +324,7 @@ export class EventsProcessor {
                     distinctId,
                     previousDistinctId,
                 ])
-            } catch (error) {
+            } catch (error: any) {
                 Sentry.captureException(error)
                 // Catch race condition where in between getting and creating,
                 // another request already created this person
@@ -395,7 +395,7 @@ export class EventsProcessor {
         while (true) {
             try {
                 await this.db.moveDistinctIds(otherPerson, mergeInto)
-            } catch (error) {
+            } catch (error: any) {
                 Sentry.captureException(error, {
                     extra: { mergeInto, mergeIntoDistinctId, otherPerson, otherPersonDistinctId },
                 })
@@ -414,7 +414,7 @@ export class EventsProcessor {
             try {
                 await this.db.deletePerson(otherPerson)
                 break // All OK, exiting retry loop
-            } catch (error) {
+            } catch (error: any) {
                 if (!(error instanceof DatabaseError)) {
                     throw error // Very much not OK, this is some completely unexpected error
                 }
@@ -615,7 +615,7 @@ export class EventsProcessor {
             // Catch race condition where in between getting and creating, another request already created this user
             try {
                 await this.db.createPerson(sentAt, {}, teamId, null, false, personUuid.toString(), [distinctId])
-            } catch (error) {
+            } catch (error: any) {
                 Sentry.captureException(error, { extra: { teamId, distinctId, sentAt, personUuid } })
             }
         }

src/worker/plugins/loadPlugin.ts

@@ -23,7 +23,7 @@ export async function loadPlugin(server: Hub, pluginConfig: PluginConfig): Promi
                 try {
                     const jsonBuffer = fs.readFileSync(configPath)
                     config = JSON.parse(jsonBuffer.toString())
-                } catch (e) {
+                } catch (e: any) {
                     pluginConfig.vm?.failInitialization!()
                     await processError(
                         server,
@@ -61,7 +61,7 @@ export async function loadPlugin(server: Hub, pluginConfig: PluginConfig): Promi
             if (json) {
                 try {
                     config = JSON.parse(json)
-                } catch (error) {
+                } catch (error: any) {
                     pluginConfig.vm?.failInitialization!()
                     await processError(server, pluginConfig, `Can not load plugin.json for ${pluginDigest(plugin)}`)
                     return false
@@ -88,7 +88,7 @@ export async function loadPlugin(server: Hub, pluginConfig: PluginConfig): Promi
                 `Tried using undownloaded remote ${pluginDigest(plugin)}, which is not supported!`
             )
         }
-    } catch (error) {
+    } catch (error: any) {
         pluginConfig.vm?.failInitialization!()
         await processError(server, pluginConfig, error)
     }