Do not set network carrier if empty (#66)

PostHog · Nov 14, 2023 · d812492 · d812492
1 parent 8f91b8e
commit d812492
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Next
 
+- Do not set `$network_carrier` property if empty ([#66](https://github.com/PostHog/posthog-android/pull/66))
+
 ## 3.0.0-beta.6 - 2023-11-14
 
 - Add a `propertiesSanitizer` callback configuration ([#64](https://github.com/PostHog/posthog-android/pull/64))

diff --git a/posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidContext.kt b/posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidContext.kt
@@ -80,7 +80,10 @@ internal class PostHogAndroidContext(
         }
 
         context.telephonyManager()?.let {
-            dynamicContext["\$network_carrier"] = it.networkOperatorName
+            val networkOperatorName = it.networkOperatorName
+            if (!networkOperatorName.isNullOrEmpty()) {
+                dynamicContext["\$network_carrier"] = networkOperatorName
+            }
         }
 
         return dynamicContext