Upsert flags when loading feature flags with computed errors #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Oct 5, 2023
| @@ -131,7 +134,7 @@ internal class PostHogFeatureFlagsTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `merge feature flags if no errors`() { | |||
| fun `merge feature flags if there are errors`() { | |||
There was a problem hiding this comment.
cheaper than the 1 billion dollar mistake tho :D
There was a problem hiding this comment.
I'd find these two easier to think about if they were generated by a method. So I could see the difference is the payload and the errorsWhileComputingFlags
But it's stylistic and easy to change so non-blocking
There was a problem hiding this comment.
yeah, I agree, that's why I named the files this way, it's a bit more obvious but there's no syntax highlighting for JSONs represented as Strings so it's also not ideal.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
https://github.com/PostHog/posthog-js-lite/blob/4a707fdc660785c187e0bfd99ec2df1887afcf5c/posthog-core/src/index.ts#L931
I did the wrong check.
Refactor for reading the JSON from resources instead of strings, its easier to maintain and read due to identation.
💚 How did you test it?
Unit tests
📝 Checklist