Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK only sends the event once per flag #47

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

https://github.com/PostHog/posthog-ios-recorder/pull/6#discussion_r1354591017

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto
Copy link
Member Author

marandaneto commented Oct 11, 2023

@neilkakkar I am tagging you on feature flag PRs but feel free to just "this is ok and makes sense" rather than line by line.
Since SDKs do different things sometimes, its always good to have a quick look before either introducing a new behaviour or the wrong one =D

Copy link

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment to fix, otherwise LGTM!

@marandaneto marandaneto merged commit 9f906fe into main Oct 11, 2023
7 checks passed
@marandaneto marandaneto deleted the chore/cache-feature-flags-called branch October 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants