Pick up consumer proguard rules correctly #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Nov 13, 2023
| @@ -17,15 +17,9 @@ org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8 | |||
| android.useAndroidX=true | |||
| # Kotlin code style for this project: "official" or "obsolete": | |||
| kotlin.code.style=official | |||
| # Enables namespacing of each library's R class so that its R class includes only the | |||
There was a problem hiding this comment.
Those are default values from >= AGP 8, so removing them
marandaneto
commented
Nov 13, 2023
| @@ -32,7 +31,7 @@ android { | |||
|
|
|||
| buildTypes { | |||
| release { | |||
| consumerProguardFiles("proguard-rules.pro") | |||
| consumerProguardFiles("consumer-rules.pro") | |||
There was a problem hiding this comment.
The file name didn't match, probably a typo since its correct in L24.
benjackwhite
approved these changes
Nov 13, 2023
Hopefully :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
If Proguard/R8 removed the classes/methods/ctor not referenced directly.
https://github.com/google/gson/blob/2658aca66a1d0f097794a5ad5eb33c095a8f8d5d/gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java#L273C39-L273C67
💚 How did you test it?
Running the sample with R8 enabled.
📝 Checklist