Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooling to latest version #54

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Update tooling to latest version #54

merged 8 commits into from
Nov 6, 2023

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Oct 10, 2023 •
edited
Loading

Reason:

  • Otherwise you can't use the latest Android tooling or latest supported Java (who still uses Java 7 only?)
  • Deprecations

TODO:

  • Migrate Flutter engine plugin to min v2 or v3 and increase the Flutter min version (not on this PR).

2x2xplz and others added 4 commits July 6, 2023 23:02
@2x2xplz
eliminated Flutter compiler warnings
cecf17e 
updated Gradle Wrapper version, Android Tools plugin version, and edited .java file to eliminate the compiler warnings
@marandaneto
Merge branch 'master' into master
eb0aadf
@marandaneto
Update tooling to latest versions
55906f6
@marandaneto
fix imports
29dfccf
@marandaneto marandaneto changed the title eliminated Flutter compiler warnings Update tooling to latest version Oct 10, 2023
marandaneto
marandaneto commented Oct 10, 2023
View reviewed changes
android/src/main/java/com/posthog/posthog_flutter/PosthogFlutterPlugin.java

// Merges [newMap] into [original], *not* preserving [original]
// keys (deep) in case of conflicts.
private static Map deepMerge(Map original, Map newMap) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method was not used

marandaneto
marandaneto commented Oct 10, 2023
View reviewed changes
android/src/main/java/com/posthog/posthog_flutter/PosthogFlutterPlugin.java
@@ -38,6 +35,7 @@ public class PosthogFlutterPlugin implements MethodCallHandler, FlutterPlugin {
static HashMap<String, Object> appendToContextMiddleware;

/** Plugin registration. */
@SuppressWarnings("deprecation")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate to the new plugin

@marandaneto marandaneto marked this pull request as ready for review November 2, 2023 15:08
@marandaneto
Copy link
Member Author

@benjackwhite I would love a quick scan here (just tooling anyway), I forgot to make it ready for review a few weeks ago.

benjackwhite
benjackwhite approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me

@marandaneto marandaneto merged commit 4af66d1 into master Nov 6, 2023
1 check passed
@marandaneto marandaneto deleted the chore/update-tooling branch November 6, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @benjackwhite @2x2xplz