Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add flush method #92

Merged
merged 3 commits into from
Mar 7, 2024
Merged

chore: add flush method #92

merged 3 commits into from
Mar 7, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #85 (comment)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team March 7, 2024 13:46
@marandaneto marandaneto marked this pull request as ready for review March 7, 2024 13:47
@marandaneto marandaneto mentioned this pull request Mar 7, 2024
Closed
daibhin
daibhin approved these changes Mar 7, 2024
View reviewed changes
Copy link

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the open question on web

@marandaneto marandaneto merged commit d254a15 into main Mar 7, 2024
4 checks passed
@marandaneto marandaneto deleted the chore/add-flush branch March 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra left review comments

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Events Immediately After Startup
3 participants
@marandaneto @pauldambra @daibhin