-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Allow overriding the route filtering using a ctor param routeFilter
#95
Conversation
one way to make this non-breaking for existing customers is to make isTrackableRoute a class constructor argument with a default that can be overridden you can see that pattern here in i bet if you copy paste this but rename the typedef to you could provide the current one as a default and the new one as an alternative exported from the package related discussion: https://twitter.com/ue_man/status/1775125806789894437 |
routeFilter
Makes sense, this tweet convinced me, better to allow the customization, fixes are pushed, thanks for the review. |
💡 Motivation and Context
https://twitter.com/luke_pighetti/status/1774906968886366545
💚 How did you test it?
Using a fake
PosthogFlutterPlatformInterface
, it was the easiest way to test it and not break or add any public APIs📝 Checklist