-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Vercel AI + Fix #351
Fix: Vercel AI + Fix #351
Conversation
Size Change: 0 B Total Size: 109 kB ℹ️ View Unchanged
|
The approach seems reasonable. Version 3.4.0 introduced OpenTelemetry tracing. According to the NPM, version 3.2 is still the most popular version with 340k downloads. I would go with this approach as it's the most seamless and does not require version updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking. Merge it if it's urgent.
@@ -27,8 +27,10 @@ | |||
"llm" | |||
], | |||
"dependencies": { | |||
"ai": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make both ai and openai peer dependencies. Is there any reason to keep them in dependencies? Under peer deps, the user is in control of which version they want to use.
posthog_trace_id: string | ||
posthog_properties?: Record<string, any> | ||
posthog_privacy_mode?: boolean | ||
posthog_groups?: string[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a camel case for parameters. I think the packages in this repo all use camel case.
https://www.loom.com/share/a5a02c23073943559b204ecfcb3e11cc