Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vercel AI + Fix #351

Merged
merged 12 commits into from
Jan 21, 2025
Merged

Fix: Vercel AI + Fix #351

merged 12 commits into from
Jan 21, 2025

Conversation

k11kirky
Copy link
Contributor

Copy link

github-actions bot commented Jan 21, 2025

Size Change: 0 B

Total Size: 109 kB

ℹ️ View Unchanged
Filename Size
posthog-node/lib/index.cjs.js 20.8 kB
posthog-node/lib/index.esm.js 20.7 kB
posthog-react-native/lib/posthog-core/src/eventemitter.js 1.08 kB
posthog-react-native/lib/posthog-core/src/index.js 10 kB
posthog-react-native/lib/posthog-core/src/lz-string.js 1.42 kB
posthog-react-native/lib/posthog-core/src/types.js 420 B
posthog-react-native/lib/posthog-core/src/utils.js 870 B
posthog-react-native/lib/posthog-core/src/vendor/uuidv7.js 2.04 kB
posthog-react-native/lib/posthog-react-native/index.js 485 B
posthog-react-native/lib/posthog-react-native/src/autocapture.js 1.8 kB
posthog-react-native/lib/posthog-react-native/src/frameworks/wix-navigation.js 651 B
posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlag.js 437 B
posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlags.js 362 B
posthog-react-native/lib/posthog-react-native/src/hooks/useLifecycleTracker.js 416 B
posthog-react-native/lib/posthog-react-native/src/hooks/useNavigationTracker.js 628 B
posthog-react-native/lib/posthog-react-native/src/hooks/usePostHog.js 249 B
posthog-react-native/lib/posthog-react-native/src/legacy.js 810 B
posthog-react-native/lib/posthog-react-native/src/native-deps.js 1.2 kB
posthog-react-native/lib/posthog-react-native/src/optional/OptionalAsyncStorage.js 183 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoApplication.js 215 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoDevice.js 211 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoFileSystem.js 224 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoLocalization.js 216 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeDeviceInfo.js 220 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigation.js 218 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigationWix.js 222 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalSessionReplay.js 231 B
posthog-react-native/lib/posthog-react-native/src/posthog-rn.js 4.42 kB
posthog-react-native/lib/posthog-react-native/src/PostHogContext.js 210 B
posthog-react-native/lib/posthog-react-native/src/PostHogProvider.js 1.57 kB
posthog-react-native/lib/posthog-react-native/src/storage.js 1.09 kB
posthog-react-native/lib/posthog-react-native/src/types.js 90 B
posthog-react-native/lib/posthog-react-native/src/version.js 123 B
posthog-web/lib/index.cjs.js 17.8 kB
posthog-web/lib/index.esm.js 17.8 kB

compressed-size-action

@skoob13
Copy link

skoob13 commented Jan 21, 2025

The approach seems reasonable. Version 3.4.0 introduced OpenTelemetry tracing. According to the NPM, version 3.2 is still the most popular version with 340k downloads. I would go with this approach as it's the most seamless and does not require version updates.

@k11kirky k11kirky marked this pull request as ready for review January 21, 2025 17:54
@k11kirky k11kirky changed the title WIP: Vercel AI POC Fix: Vercel AI + Fix Jan 21, 2025
@k11kirky k11kirky enabled auto-merge (squash) January 21, 2025 18:42
Copy link

@skoob13 skoob13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. Merge it if it's urgent.

@@ -27,8 +27,10 @@
"llm"
],
"dependencies": {
"ai": "^4.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make both ai and openai peer dependencies. Is there any reason to keep them in dependencies? Under peer deps, the user is in control of which version they want to use.

posthog_trace_id: string
posthog_properties?: Record<string, any>
posthog_privacy_mode?: boolean
posthog_groups?: string[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a camel case for parameters. I think the packages in this repo all use camel case.

@k11kirky k11kirky merged commit 9ddb478 into main Jan 21, 2025
4 checks passed
@k11kirky k11kirky deleted the feat/vercel-middleware branch January 21, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants