Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow linked flag variants to control recording #1040

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

pauldambra
Copy link
Member

see https://posthoghelp.zendesk.com/agent/tickets/10806

Prepares the ground for a change in posthog allowing people to choose boolean linked flags or a particular variant of a multivariant flag to control recordings

fly-by adds an _isNullish check since typing _isNull(blah) || _isUndefined(blah) was tiring me out

Copy link

github-actions bot commented Feb 23, 2024

Size Change: +163 B (0%)

Total Size: 860 kB

Filename Size Change
dist/array.full.js 185 kB +38 B (0%)
dist/array.js 126 kB +40 B (0%)
dist/es.js 126 kB +40 B (0%)
dist/module.js 126 kB +40 B (0%)
dist/recorder-v2.js 106 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder.js 58.6 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@pauldambra pauldambra marked this pull request as ready for review February 24, 2024 11:28
@pauldambra pauldambra requested a review from a team February 24, 2024 11:28
@pauldambra pauldambra added the bump minor Bump minor version when this PR gets merged label Feb 27, 2024
@pauldambra pauldambra merged commit 1c34e32 into main Feb 28, 2024
13 checks passed
@pauldambra pauldambra deleted the feat/allow-linked-variant branch February 28, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants