Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rrweb #21734

Merged
merged 2 commits into from
Apr 23, 2024
Merged

chore: upgrade rrweb #21734

merged 2 commits into from
Apr 23, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 22, 2024

Problem

There is a new version of rrweb out that includes some of our patches

Changes

  • Delete old patch
  • Reapply relevant changes

let depthBrackets = 0;
+ let currentStringChar = null;
for (const char of input) {
- if (char === '(') {
Copy link
Contributor Author

@daibhin daibhin Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply unreleased changes in rrweb-io/rrweb#1440. Originally patched in #21427

@daibhin daibhin requested a review from a team April 22, 2024 18:37
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can still playback locally

@daibhin daibhin merged commit 9072210 into master Apr 23, 2024
103 checks passed
@daibhin daibhin deleted the dn-chore/upgrade-rrweb branch April 23, 2024 14:44
@daibhin daibhin mentioned this pull request Apr 23, 2024
daibhin added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants