chore(editor-3000): extract datavizlogic #26266
Open
+43
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto dw-sidebar-integration
EDsCODE
changed the title
Gilbert09
approved these changes
Nov 19, 2024
| @@ -559,31 +558,31 @@ export const dataVisualizationLogic = kea<dataVisualizationLogicType>([ | |||
| return columns.filter((n) => n.type.isNumerical) | |||
| }, | |||
| ], | |||
| dashboardId: [(_state, props) => [props.dashboardId], (dashboardId) => dashboardId], | |||
There was a problem hiding this comment.
Gotta do something like this to get the type checks to pass:
dashboardId: [(_state, props) => [props.dashboardId ?? (() => undefined)], (dashboardId) => dashboardId],
| @@ -45,7 +46,7 @@ import { variablesLogic } from './Components/Variables/variablesLogic' | |||
| import { dataVisualizationLogic, DataVisualizationLogicProps } from './dataVisualizationLogic' | |||
| import { displayLogic } from './displayLogic' | |||
|
|
|||
| interface DataTableVisualizationProps { | |||
| export interface DataTableVisualizationProps { | |||
There was a problem hiding this comment.
Any reason this now needs to be exported? Dont see it being used anywhere else
…into dw-editor-visualization
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?