feat: actions as saved filters #26283
Conversation
|
Size Change: +82 B (+0.01%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
…sthog into feat/actions-as-saved-filters
| saveFilterGroupAsAction: ({ propertyGroupIndex }) => { | ||
| const filterGroup = values.filters.values[propertyGroupIndex] | ||
|
|
||
| router.actions.push(urls.createAction(filterGroup)) |
There was a problem hiding this comment.
any way to get this to open in a new tab?
📸 UI snapshots have been updated24 snapshot changes in total. 0 added, 24 modified, 0 deleted:
Triggered by this commit. |
|
Implementing saved filters as actions could make sense, but I think having to explain that to a user (and have every user understand it to use this feature) is a little confusing Right now, they can save filters as an action, but then if they want to reuse those, do they need to use an action instead of selecting the event and applying "saved filters"? Once they've created an action, can the "saved filter" only apply to the event type they created the action with? Or how could they take the same set of saved filters and apply them to different insights on different events? I guess it feels to me that the usability of this approach isn't quite there - saved filters might need to be given a bit more respect as their own independent entity than just being a shortcut to actions. But please let me know if I'm misunderstanding how this should flow or not getting the functionality! |
Problem
No way to reuse filters across the app.
Actions are essentially saved filters as you can save the filters there and then select the action to view series on an insight.
On the activity page though, there's no way to pick an action to filter for events (people have requested saved filters there as well), so have added a way to pick 'saved filters'/actions there as well.
Changes
DataTablecomponent.Also tackles part of Saved filters #20314 in letting
DataTablehave a way to pick 'Saved Filters'.actions_as_saved_filters.mov
action.from.filters.mov
This is just one approach, open to suggestions to improve the flow :)
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Tested Locally, will add E2E tests once everyone approves the UX.