Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(funnels): allow customization of result dataset colors #26296

Draft
wants to merge 13 commits into
base: insight-colors
Choose a base branch
from
Draft

feat(funnels): allow customization of result dataset colors #26296

wants to merge 13 commits into from
+480 −254

Commits on Nov 19, 2024

  1. move ResultCustomizationsModal to InsightVizDisplay

    @thmsobrmlr
    thmsobrmlr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ba28634 View commit details
    Browse the repository at this point in the history

  2. add icon button for funnels

    @thmsobrmlr
    thmsobrmlr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    84d9155 View commit details
    Browse the repository at this point in the history

  3. allow setting customizations for funnels

    @thmsobrmlr
    thmsobrmlr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a898fd7 View commit details
    Browse the repository at this point in the history

  4. display (almost) in funnel step table

    @thmsobrmlr
    thmsobrmlr committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    20fc3c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. display in step bars and add experiments special handling

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c1fc1dc View commit details
    Browse the repository at this point in the history

  2. fix detailled results table in experiments

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bce6eb5 View commit details
    Browse the repository at this point in the history

  3. don't display the edit button for funnels in experiments

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e89d3dd View commit details
    Browse the repository at this point in the history

  4. add support for top-to-bottom funnels

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    51983f4 View commit details
    Browse the repository at this point in the history

  5. move resultCustomizations from query root to trendsFilter

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c3b8492 View commit details
    Browse the repository at this point in the history

  6. make changes to resultCustomizations a visualization only change (no … 

    …new query issued)
    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    80c767b View commit details
    Browse the repository at this point in the history

  7. fix supportsResultCustomizationBy

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    24ef09b View commit details
    Browse the repository at this point in the history

  8. Update UI snapshots for chromium (2)

    @github-actions
    github-actions[bot] committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    729c857 View commit details
    Browse the repository at this point in the history

  9. fix cached properties and types

    @thmsobrmlr
    thmsobrmlr committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    eff8077 View commit details
    Browse the repository at this point in the history