feat(data-warehouse): New pipeline WIP #26341
Draft
+535
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
reviewed
Nov 21, 2024
| raise ValueError(f"No default value defined for type: {pyarrow_type}") | ||
|
|
||
|
|
||
| def _update_incrementality(schema: ExternalDataSchema | None, table: pa.Table, logger: FilteringBoundLogger) -> None: |
| schema.update_incremental_field_last_value(last_value) | ||
|
|
||
|
|
||
| def _update_job_row_count(job_id: str, count: int, logger: FilteringBoundLogger) -> None: |
There was a problem hiding this comment.
Why is this outside of the Pipeline class?
| @@ -425,12 +433,18 @@ def _run( | |||
| schema: ExternalDataSchema, | |||
| reset_pipeline: bool, | |||
| ): | |||
| table_row_counts = DataImportPipelineSync(job_inputs, source, logger, reset_pipeline, schema.is_incremental).run() | |||
| total_rows_synced = sum(table_row_counts.values()) | |||
| if settings.DEBUG: | |||
There was a problem hiding this comment.
Can base this off the env var settings.TEMPORAL_TASK_QUEUE = v2-data-warehouse-task-queue
| if not primary_keys or len(primary_keys) == 0: | ||
| raise Exception("Primary key required for incremental syncs") | ||
|
|
||
| delta_table.merge( |
There was a problem hiding this comment.
Will function work on an empty delta table? Asking because it'd clean up this logic a bunch if we could just handle if delta_table is None before this entire if block
| for column_name in table.column_names: | ||
| column = table.column(column_name) | ||
| if pa.types.is_struct(column.type) or pa.types.is_list(column.type): | ||
| json_column = pa.array([json.dumps(row.as_py()) if row.as_py() is not None else None for row in column]) |
There was a problem hiding this comment.
Out of scope here but an issue I just discovered that might be addressable here. clickhouse s3 can't deserialize a list like ["test"]
There was a problem hiding this comment.
Do you more context to this? A support ticket maybe?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?