Setup Funnel Unordered persons and Testing #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for conversion window;
… cleanup via destroy() method
…ed funnel_persons and funnel_trends_persons into individual classes;
…com:PostHog/posthog into funnel-persons-pagination-conversion-window
…to funnel-unordered-persons
neilkakkar
commented
Jul 1, 2021
| @@ -15,7 +15,7 @@ | |||
| HUMAN_READABLE_TIMESTAMP_FORMAT = "%a. %-d %b" | |||
|
|
|||
|
|
|||
| class ClickhouseFunnelTrends(ClickhouseFunnelNew): | |||
| class ClickhouseFunnelTrends(ClickhouseFunnelBase): | |||
There was a problem hiding this comment.
Eventually, I think visualisation like Trends should inherit from the different types of ordered funnels, and use their now-new get_step_counts_query() as the seed query, but now's not the time for it. ( Want atleast a pattern of 2 before we generalise, so we don't create the wrong abstractions)
|
I added the step timings into this query so that it's consistent. The timing themselves don't make much sense at the moment (can end up with negative values). This is worth investigating but I don't want it to be a blocker to get this merged because we can apply this persons pattern elsewhere |
EDsCODE
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fun stuff: Writing tests as I mentioned in https://github.com/PostHog/posthog/pull/4892/files#r660477225 helped me find bugs in our
FunnelPersonsclass xD (sometimes, people are duplicated, more in the PR)This PR: sets up a general method of creating
Personsfor queries, and tests them along with their non-Person class. I think it's imperative to test these two together, as this ensures (1) we don't duplicate all the tests twice, (2) what gets called together, gets tested togetherChecklist