-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Paths Grouping on backend #6052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as other comments. Mostly looks good. The PR description could use more detailing as to what parameters we're now able to use
Also, what's the difference between % and * you were describing above?
Based on: #4364 (comment) , decided to get rid of second operator. The difference was: One did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
* enable paths grouping on backend * write API test for path groupings * remove % only use *
Changes
Part of #4364
Goes after #6035
Decisions made:
*
matches everything (.*
regex). We don't allow custom regexes. We'll probably have to experiment to figure out what are the best operators to expose, but this seemed good enough for now.PathEventQuery
. Doing things like this, start & end points respect aggregations as well, and felt cleaner than doing it in the middle, since that would involve keeping timestamps in order as well. (when 2 events become duplicates because of grouping, these effectively become duplicate events that we dedupe)Introducing the
path_groupings
API parameter, which takes a list of strings to match. For example, see test:posthog/ee/clickhouse/views/test/test_clickhouse_paths.py
Line 102 in 49b892b
Checklist