refix toogle column weird bug, change to columns property as visibleC…

…olumns is computed property (#1439)
Power-Components · Mar 1, 2024 · 8d01f53 · 8d01f53
1 parent 0036907
commit 8d01f53
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/Concerns/Listeners.php b/src/Concerns/Listeners.php
@@ -26,17 +26,13 @@ public function toggleableChanged(string $id, string $field, string $value): voi
     #[On('pg:toggleColumn-{tableName}')]
     public function toggleColumn(string $field): void
     {
-        $this->visibleColumns = $this->visibleColumns->map(function (\stdClass | array $column) use ($field) {
-            if (is_object($column) && $column->field === $field) {
-                $column->hidden = !$column->hidden;
-            }
+        foreach ($this->columns as &$column) {
+            if (data_get($column, 'field') === $field) {
+                data_set($column, 'hidden', !data_get($column, 'hidden'));
 
-            if (is_array($column) && $column['field'] === $field) {
-                $column['hidden'] = !$column['hidden'];
+                break;
             }
-
-            return $column;
-        });
+        }
 
         $this->persistState('columns');
     }

diff --git a/src/PowerGridComponent.php b/src/PowerGridComponent.php
@@ -20,7 +20,7 @@
 /**
  * @property-read mixed $getCachedData
  * @property-read bool $hasColumnFilters
- * @property array|BaseCollection $visibleColumns
+ * @property-read array|BaseCollection $visibleColumns
  */
 class PowerGridComponent extends Component
 {