Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves filter logic #1286

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Improves filter logic #1286

merged 8 commits into from
Dec 11, 2023

Conversation

luanfreitasdev
Copy link
Collaborator

@luanfreitasdev luanfreitasdev commented Dec 7, 2023 •
edited
Loading

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.

Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

This Pr fixes filters when the second argument in a filter uses dot notation. Ex:

Filter::number('category_name, 'categories.id')

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@luanfreitasdev luanfreitasdev mentioned this pull request Dec 7, 2023
Closed
5 tasks
@luanfreitasdev luanfreitasdev marked this pull request as ready for review December 8, 2023 19:49
@luanfreitasdev luanfreitasdev merged commit ffbc583 into 5.x Dec 11, 2023
18 checks passed
@luanfreitasdev luanfreitasdev deleted the enhancement/filters branch December 11, 2023 21:00
luanfreitasdev added a commit that referenced this pull request Dec 19, 2023
@luanfreitasdev
Fix Filters (bug added in #1286) (#1301)
b2efd73 
* fix filters requests

* run pint

* Start add filters cypress test

* Fix blade name

* Fix cypress test + add filter number

* Fix cypress test + add filter number

* Fix cypress test + add filter number

* Fix cypress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luanfreitasdev