Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Filters Structure #1356

Merged
merged 22 commits into from
Feb 1, 2024
Merged

Improve Filters Structure #1356

merged 22 commits into from
Feb 1, 2024

Conversation

luanfreitasdev
Copy link
Collaborator

@luanfreitasdev luanfreitasdev commented Jan 27, 2024

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description


Add automatic queryString

protected function queryString(): array
{
    return [
         'search' => ['except' => ''],
         'page' => ['except' => 1],
         ...$this->powerGridQueryString(),
    ];
}

Result:

?name=Ark&category=1&price_start=8&price_end=10&diet=1


TODO

  • - Dynamic Filters
  • - Outside Filters
  • - Automatic queryString
  • - EnumFilter
  • - Tests

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

Base automatically changed from deprecated-add-columns to 5.x January 30, 2024 13:32
@luanfreitasdev luanfreitasdev marked this pull request as ready for review February 1, 2024 00:59
@luanfreitasdev luanfreitasdev merged commit 86220a7 into 5.x Feb 1, 2024
16 checks passed
@luanfreitasdev luanfreitasdev deleted the improve/structure-filters branch February 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant