Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Footer::pageName #1364

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Add Footer::pageName #1364

merged 3 commits into from
Feb 1, 2024

Conversation

luanfreitasdev
Copy link
Collaborator

@luanfreitasdev luanfreitasdev commented Jan 31, 2024

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

URL: <! -- localhost/?customerPage=2&usersPage=2 -->

<div>
    <livewire:customers-table />
    <livewire:users-table />
</div>

// \App\Livewire\CustomersTable::class

Footer::make()
      ->pageName('customerPage')

// \App\Livewire\UsersTable::class
Footer::make()
       ->pageName('usersPage')

Related Issue(s): #1363.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@dansysanalyst
Copy link
Member

dansysanalyst commented Jan 31, 2024

Awesome PR.

I have pushed a commit limiting pageName to be alphanumeric.

I noticed a strange behavior when setting my page name to "Ντόναλντ" (Donald, in Greek). It duplicated the query string field.

CleanShot 2024-02-01 at 00 48 02@2x

@luanfreitasdev luanfreitasdev merged commit a6eaba9 into 5.x Feb 1, 2024
28 checks passed
@luanfreitasdev luanfreitasdev deleted the feature-page-name branch February 1, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants