Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action buttons to appear inline #1395

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix action buttons to appear inline #1395

merged 1 commit into from
Feb 6, 2024

Conversation

akulmehta
Copy link
Collaborator

⚡ PowerGrid - Pull Request


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

Earlier versions of PowerGrid would allow all action buttons to be inline within a row, like:

image

Since 5.x this has changed as it is contained in individual div elements, making it appear more cluttered like:

image

This PR proposes to change it to span elements to fix this and get the same UI as previous versions.

Please Note - I have checked this only with Bootstrap and not with the Tailwind stack, so I am not sure if this breaks something with the Tailwind UI.

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@luanfreitasdev
Copy link
Collaborator

Thanks for this PR! This would not be able to break in the tailwind.

@luanfreitasdev luanfreitasdev merged commit 614c19e into Power-Components:5.x Feb 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants