Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix toggle column not working on first time toogling #1431

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jhonoryza
Copy link
Contributor

@jhonoryza jhonoryza commented Feb 27, 2024


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

bug fix toggle column not working on first time toogling after refresh browser

Screen.Recording.2024-02-28.at.2.57.53.AM.mov

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@jhonoryza
Copy link
Contributor Author

is there a reason why make $visibleColumns as read only property ?

i try this simple example
image

got error:
Indirect modification of overloaded element of Illuminate\Support\Collection has no effect in /var/www/html/vendor/laravel/framework/src/Illuminate/Collections/helpers.php on line 124

@luanfreitasdev
Copy link
Collaborator

Thank you @jhonoryza !

I have fixed the phpstan error

@luanfreitasdev luanfreitasdev merged commit 0036907 into Power-Components:5.x Feb 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants