Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEMPORARY FIX] Data Export doesn't work when using withAvg() #1560

Merged

Conversation

dansysanalyst
Copy link
Member

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

This Pull Request is a temporary fix for problems exporting data under certain conditions, for example when using withAvg(). While I had this problem in the Demo, I could not replicate the bug in the tests.

In the bug I encountered, the Exception is thrown because WithExport tries to access a field that doesn't exist. This doesn't prevent data being exported, as existing fields will be included in the CSV/XLS. However, the Exception will impact the user experience.

I decided to add a rescure() to let the application continue running, but this is NOT A FIX and we should continue investigating the issue.

Related Issue(s): #1540

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@luanfreitasdev luanfreitasdev merged commit 204e6e7 into Power-Components:5.x May 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants