-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: confirmation before any action. #1599
feat: confirmation before any action. #1599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a doc about this? in https://livewire-powergrid.com/table-features/button-class.html#button-methods
Thank you for your feedback. I will make the requested changes and submit a docs pull request to the docs repo within a few days. |
Thank you for this PR! |
Hi @luanfreitasdev, I marked all requested changes as resolved. But in PR it still shows that one change is requested. Why is this showing this? Did I need to make any other changes regarding this PR? |
⚡ PowerGrid - Pull Request
Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.
Motivation
Description
Feature:
This PR adds a confirmation popup before executing any action via action buttons.
Purpose:
To prevent unintended actions and improve user experience by adding an extra layer of confirmation.
As we know we use macros for additional functionality to add id and trigger dispatch events. In the same way, we can add wire:confirm attribute to buttons.
Read more Livewire wire:confirm
Example:
Result:
Documentation
This PR requires Documentation update?